[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix dimensions for several output variables

From: Neil Puttock
Subject: Re: [PATCH] Fix dimensions for several output variables
Date: Sun, 7 Sep 2008 16:20:41 +0100

2008/9/7 Patrick McCarty <address@hidden>:
> Hello,
> Attached is a patch to fix the interpretation of dimensions for a few
> output variables.  Currently, no matter the unit specified, the
> dimensions for the variables listed in the patch are converted to
> millimeters, but are interpreted as staff-spaces.  This leads to
> measurements that are proportional to the staff size instead of
> precise measurements.
> Only scm/paper.scm is modified, and since the listed dimensions can
> now be correctly set, the default settings in ly/ may
> need to be adjusted to taste.  ;-)

A few comments:

The regression test now has only
two pages, so it either needs a corrected description, or changing
slightly to keep it on three pages.

Can you amend the section on annotating spacing to reflect the
changes? As far as I can see, all the annotations are shown in
staff-spaces only.

Does the paper variable ledger-line-thickness actually do anything
useful? It isn't referenced in any other .scm file.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]