[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Nested book parts

From: nicolas . sceaux
Subject: Re: Nested book parts
Date: Sat, 18 Oct 2008 08:10:29 -0700
File lily/ (right):
Line 139: Book::add_bookpart ()
On 2008/10/15 01:06:06, joeneeman wrote:
This method confused me for a while (because it has quite a different
from add_bookpart(SCM)). I suggest renaming this method and adding a
along the lines of "all scores before an explicit \bookpart are
lumped into their own separate bookpart".

/* Before an explicit \bookpart is encountered, scores are added to the
 * But once a bookpart is added, the previous scores shall be collected
 * a new bookpart.
Book::add_scores_to_bookpart ()
Line 190: Book::process (Output_def *default_paper,
On 2008/10/15 01:06:06, joeneeman wrote:
This method is becoming very long.

File lily/include/book.hh (right):
Line 35: void add_bookpart ();
On 2008/10/15 01:29:22, hanwenn wrote:
On 2008/10/15 01:06:06, joeneeman wrote:
> Can this be private? Yeah, I know everything else here is public,
but that's
> reason to perpetuate the problem.

actually, my preference is for protected, unless the method does
really internal (like breaking invariants.)

Line 38: bool error_found ();
On 2008/10/15 01:06:06, joeneeman wrote:
also private?

File lily/ (right):
Line 43: vsize first_page_num = robust_scm2int
(book_->paper_->c_variable ("part-first-page-number"), 1);
On 2008/10/15 01:06:06, joeneeman wrote:
Do we really need new variables for properties in book parts (as
opposed to
using some cascading to allow bookparts to override properties in the
parent)? I
could see this leading to an explosion of properties.

indeed the first-page-number property can be used in children parts,
instead of a new property.
File lily/ (right):
Line 266: bool last_from_part = (i == lines_per_page.size () - 1);
On 2008/10/15 01:06:06, joeneeman wrote:
I'm not sure this is the logic we want here. I think we want to treat
the last
page in a bookpart the same as the last page in a book. This would
give the
per-score ragged-last-bottom feature that some people have been asking

`last_from_part' is used to achieve what you propose: treat the part
last page as the one that gets special spacing with ragged-last-bottom.
`last_from_book' is used to know where to put the tagline. We do not
want  a tagline at every last page of book parts.
File lily/ (right):
Line 112: Paper_book::output_aux (SCM output_channel,
On 2008/10/15 01:06:06, joeneeman wrote:
This gets simpler if you no longer care about is_first and is_last...

`is_first' is useless indeed (remainer of previous implementation)
but `is_last' is useful, not to put tagline on every part last page.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]