Re: [PATCH] Fix for bug #218 (center staccato over stem instead of notehead)

[Maximilian Albert]

2008/12/10 Han-Wen Nienhuys <address@hidden>:

> Some random comments:

Thanks for these suggestions! They are implemented in the attached
patches. Please let me know if you'd like some further corrections.

> - have a look at scm/script.scm to set defaults just for staccato.

Following Neil's suggestions, I set the default for staccato to 0.5
and left all other scripts alone.

> - "shifted" suggests a boolean property.  toward-stem-shift ?

Renamed.

> - do not use 'pos' - it's the name for vertical offsets in half staffspace.

OK. Lacking a better idea, I chose note-head-location and
stem-location instead. I hope it's not too clumsy.

> - use explicit type checks (ie. number? rather than (not null?))

The number check was eliminated by Neil's suggestion to use a default value.
I now use ly:grob? to check whether a stem grob exists.

> -    (if (equal? dir1 dir2) can move to before the stem-pos init

Done.

> - add a regtest. Should be short, with a short doc string explaining
> the functionality.

Done (patch #2). I hope it meets the requirements for a regtest.
Please let me know if anything is missing or wrong.

Max

0001-New-grob-property-shifted-towards-stem-allows-scri.patch
Description: Text Data

0002-Add-regression-test-for-toward-stem-shift-property.patch
Description: Text Data