Re: [PATCH] Fix for bug #218 (center staccato over stem instead of notehead)

[Han-Wen Nienhuys]

On Sun, Dec 7, 2008 at 5:34 PM, Maximilian Albert
<address@hidden> wrote:
> Hi Neil,
>
> thanks a lot for your further very helpful ideas. Attached is a patch
> for a new approach which implements your suggestion to define a new
> property. It's called 'shifted-towards-stem and can take any real
> value, where 0.0 means to keep the default position (centered on the
> note-head) and 1.0 means centered on the stem (intermediate values are
> of course possible). I also added a check whether the grob in question
> actually possesses a stem, so it works well for skips, too (perhaps
> there is a more Lilypond-ish way of doing things but as far as I could
> test, it works).

Some random comments:

- have a look at scm/script.scm to set defaults just for staccato.
- "shifted" suggests a boolean property.  toward-stem-shift ?
- do not use 'pos' - it's the name for vertical offsets in half staffspace.
- use explicit type checks (ie. number? rather than (not null?))
-    (if (equal? dir1 dir2) can move to before the stem-pos init
- add a regtest. Should be short, with a short doc string explaining
the functionality.




-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen