[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Fix crash when a stencil routine is missing
From: |
Patrick McCarty |
Subject: |
Re: [PATCH v2] Fix crash when a stencil routine is missing |
Date: |
Mon, 6 Jul 2009 10:36:36 -0700 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Mon, Jul 06, 2009 at 09:37:19AM +0200, John Mandereau wrote:
> Le dimanche 05 juillet 2009 à 18:01 -0700, Patrick McCarty a écrit :
> > On Sun, Jul 05, 2009 at 05:39:45PM -0700, Graham Percival wrote:
> > > -dwarning-as-error
> > > looks fine to me.
> >
> > I think Han-Wen suggested to enable this option for the entire
> > regression test suite, so adding this option to every single
> > regression test would not be reasonable.
> >
> > In other words, some makefile hacking is needed, which I would
> > probably need to delegate.
>
> What about the following?
>
> Best,
> John
>
>
> diff --git a/input/regression/GNUmakefile b/input/regression/GNUmakefile
> index 753d483..f1a8179 100644
> --- a/input/regression/GNUmakefile
> +++ b/input/regression/GNUmakefile
> @@ -7,3 +7,5 @@ include $(depth)/make/stepmake.make
> TITLE=LilyPond Regression Tests
>
> SUBDIRS=musicxml
> +
> +LILYPOND_BOOK_LILYPOND_FLAGS += -dwarning-as-error
This looks great! I'll save it and apply if/when the patchset is
finalized and approved.
Thanks,
Patrick
- Re: [PATCH v2] Fix crash when a stencil routine is missing, (continued)
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/05
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Werner LEMBERG, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Graham Percival, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Graham Percival, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Werner LEMBERG, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Patrick McCarty, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, Joe Neeman, 2009/07/07
- Re: [PATCH v2] Fix crash when a stencil routine is missing, John Mandereau, 2009/07/06
- Re: [PATCH v2] Fix crash when a stencil routine is missing,
Patrick McCarty <=