[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Implement new handling for \paper margin settings.

From: Carl . D . Sorensen
Subject: Implement new handling for \paper margin settings.
Date: Thu, 20 Aug 2009 12:54:08 +0000

LGTM.  I do have one comment about tests for != SCM_UNDEFINED.  It think
there's less chance of confusion when testing for "undefined" rather
than "not undefined", which is "defined".  The double negative (not
undefined) can potentially be confusing.

But this is just my opinion, and you can feel free to ignore it.

File lily/ (right):
Line 146: if (scm_paper_width != SCM_UNDEFINED
I'd prefer to see this and all of your checks for SCM_UNDEFINED) be
written as
if (scm_paper_width = SCM_UNDEFINED) ||
    (scm_left_margin = SCM_UNDEFINED) ||
    (scm_right_margin = SCM_UNDEFINED)
     Print error message
    Handle proper settings

reply via email to

[Prev in Thread] Current Thread [Next in Thread]