[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Implement new handling for \paper margin settings.

From: n . puttock
Subject: Re: Implement new handling for \paper margin settings.
Date: Fri, 21 Aug 2009 00:04:22 +0000
File lily/ (right):
Line 146: if (scm_paper_width != SCM_UNDEFINED
On 2009/08/20 12:54:08, Carl wrote:
I'd prefer to see this and all of your checks for SCM_UNDEFINED) be
written as
if (scm_paper_width = SCM_UNDEFINED) ||
     (scm_left_margin = SCM_UNDEFINED) ||
     (scm_right_margin = SCM_UNDEFINED)
      Print error message
     Handle proper settings

How about using scm_is_number () instead?
Line 156: programming_error (_ ("called normalize() on paper with
missing settings"));
space after normalize

programming errors aren't localized
Line 171: ? scm_to_double(scm_right_margin)
space after scm_to_double
Line 192: if (c_variable ("check-consistency") == SCM_BOOL_T)
could use to_boolean here

if (to_boolean (c_variable ("check-consistency")))
Line 200: warning (_ ("margins don't fit with line-width, setting
default values"));
don't -> do not
Line 211: set_variable (ly_symbol2scm ("left-margin"),
space after scm_from_double

(same for following lines)
File ly/ (left):
Line 45: between-scores-system-spacing = #'((space . 14)
(minimum-distance . 8) (padding . 1))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]