[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Move ambitus print callback to scheme

From: Nicolas Sceaux
Subject: Re: [PATCH] Move ambitus print callback to scheme
Date: Fri, 28 Aug 2009 21:16:17 +0200

Le 27 août 09 à 22:38, Neil Puttock a écrit :

2009/8/26 Carl Sorensen <address@hidden>:

The patch looks good to me.


You code the empty list as (list). I typically code the empty list as '().

It there a preference? I suspect that we ought to be consistent, although it's not highly important. It could be part of the code janitor work,

It's just something I noticed in a few places internally (these all
seem to be changes made by Nicolas) and thought it was clearer, though
admittedly I haven't been particularly consistent when deciding
between the two forms.  :)

According to R5RS, it is an error to modify a literal list.
If a function returns '(), the caller won't be allowed to
apply a modifying function on the result (eg. append!)

However, guile does not report modifying a literal list as an error,
and actually modifies it, so this is somewhat rhetorical.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]