[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Unsecure assoc calls

From: Neil Puttock
Subject: Re: Unsecure assoc calls
Date: Fri, 18 Sep 2009 20:58:16 +0100

2009/9/18 Michael Käppler <address@hidden>:

> Hmm... I forgot that ly:assoc-get throws an assert error instead of
> returning #f if it's list argument isn't a list. I reverted this for now,
> but maybe we should better output a programming error in assoc-get for this
> case?

I don't think that's necessary, since we rely on Guile to catch
type-check failures in this case.

> Sorry for missing that. However, don't you think that this '=' is
> unnecessary? The default comparison procedure is equal? and I don't see any
> differences to = that matter for this case.

I'm inclined to agree, but `=' isn't as permissive as equal?, so there
might be some logic behind it.

The revised patch checks out fine, so I've applied it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]