[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes
From: |
Graham Percival |
Subject: |
Re: [PATCH] includeGraceNotes: lyrics syllables of grace notes |
Date: |
Tue, 30 Mar 2010 19:52:29 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Mar 30, 2010 at 05:00:39PM +0200, Richard Gay wrote:
> http://lists.gnu.org/archive/html/lilypond-user/2010-03/msg00362.html
> there seem to be also other people with the same concern. Hence the
> proposed patch attached.
Wow, thanks! Especially for the doc parts. I can't speak to the
code, but there's a few doc policy issues.
Also, could we get a regression test for this feature? See
input/regression/
> @@ -1152,6 +1152,33 @@ not work if prefixed with @code{\once}. It is
> necessary to use
> @code{\set} and @code{\unset} to bracket the lyrics where melismata
> are to be ignored.
>
> address@hidden Adding syllables to grace notes
> +
> +By default, grace notes (e.g. via @code{\grace}) do not get assigned
> +syllables when using @code{\lyricsto}. This behavior can be changed by
> +setting @code{includeGraceNotes} in the Lyrics context.
We try to avoid writing text like @code{includeGraceNotes} and
simply say "By default... when using @code{\lyricsto}, but this
behavior can be changed:"
Another issue is that we try to avoid having tweaks in the main NR
text; these should be added as snippets. However, the rest of
Vocal music is a complete mess, and we don't have any doc editors
trained in dealing with snippets, so I'm fine with adding it to
the main text for now.
> address@hidden,ragged-right,quote]
> +<<
> + {
> + f'4 \appoggiatura b'32 c''4
> + \grace { f'16 [a'16] } c''2
No tabs; indentation rule is two spaces per level.
> + foo
> + \set includeGraceNotes = ##t
> + bar,
These should all have 2nd-level indentation, so four spaces.
Cheers,
- Graham