[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Tablature: proper support for tie/slur- and tie/glissando-constellat
From: |
Carl . D . Sorensen |
Subject: |
Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042) |
Date: |
Thu, 28 Oct 2010 12:53:01 +0000 |
LGTM.
However, I'm a bit nervous about putting bends as well into the
Tab_tie_follow_engraver. Not that the engraver won't work, but that the
Tab_tie_follow_engraver won't be part of the documentation.
Currently, I view Scheme engravers as a way for users (and snippets) to
add engraver functionality, but not as an optimal way to add core
functionality.
I'm not asking you to change your code, but I'm trying to send up a
caution flag to see what others might say about it.
Thanks,
Carl
http://codereview.appspot.com/2191042/diff/17001/input/regression/tablature-tie-slur-glissando.ly
File input/regression/tablature-tie-slur-glissando.ly (right):
http://codereview.appspot.com/2191042/diff/17001/input/regression/tablature-tie-slur-glissando.ly#newcode1
input/regression/tablature-tie-slur-glissando.ly:1: \version "2.13.37"
2.13.38
http://codereview.appspot.com/2191042/
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Marc Hohl, 2010/10/20
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042),
Carl . D . Sorensen <=
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Marc Hohl, 2010/10/28
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Carl Sorensen, 2010/10/28
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Valentin Villenave, 2010/10/28
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Carl Sorensen, 2010/10/28
- internals reference (was: tablature tie/slur), Graham Percival, 2010/10/29
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Neil Puttock, 2010/10/29
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Marc Hohl, 2010/10/30
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Neil Puttock, 2010/10/30
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Marc Hohl, 2010/10/31
- Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042), Carl Sorensen, 2010/10/30