[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Patch] Fix #1365: convert-ly shouldn't remove Dynamics performer group
From: |
Valentin Villenave |
Subject: |
[Patch] Fix #1365: convert-ly shouldn't remove Dynamics performer group |
Date: |
Sun, 7 Nov 2010 11:35:50 +0100 |
Greetings everybody, here's a patch that (hopefully) addresses the
low-priority issue 1365.
I'm not sure if we've ever used convert-ly to insert comments in .ly
files, but I do think we should in this specific case: the
piano-centered dynamics template has been used by a *lot* of people in
the past, and it's much more safe IMO if convert-ly puts a comment as
some kind of a placeholder.
Please have a look at the patch (since it's basically a one-line
patch, I think using Rietveld here would be overkill).
http://code.google.com/p/lilypond/issues/attachmentText?id=1365&aid=-4862281631302526021&name=0001-Convert-ly-fix-regexp-for-Dynamics-context.patch
- str = re.sub (r'(\\context\s*\{{1}[^\}]+\\name\s+"*Dynamics"*[^\}]*\}{1})',
- '', str)
+ str = re.sub
(r'(\\context\s*\{{1}[^\}]+\\type\s+\"?Engraver_group\"?\s+\\name\s+"*Dynamics"*[^\}]*\}{1})',
+ '% [Convert-ly] The Dynamics context is now
included by default.', str)
Cheers,
Valentin.
- [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performer group,
Valentin Villenave <=
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Trevor Daniels, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Graham Percival, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Trevor Daniels, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamics performergroup, Reinhold Kainhofer, 2010/11/07
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamicsperformergroup, Trevor Daniels, 2010/11/08
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamicsperformergroup, Valentin Villenave, 2010/11/08
- Re: [Patch] Fix #1365: convert-ly shouldn't remove Dynamicsperformergroup, Trevor Daniels, 2010/11/08