[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix error messages in website build (issue4428077)

From: Phil Holmes
Subject: Re: Fix error messages in website build (issue4428077)
Date: Mon, 2 May 2011 17:29:27 +0100

----- Original Message ----- From: <address@hidden>
To: <address@hidden>
Cc: <address@hidden>; <address@hidden>
Sent: Monday, May 02, 2011 4:20 PM
Subject: Re: Fix error messages in website build (issue4428077)

good start!  I'm not certain about the location of the text file (having
it inside scripts/ seems a bit weird), but the framework is definitely

Agreed. In the final analysis, I couldn't find a better place than to simply stick it next to the script file that uses it. If it was my source directory, I'd probably create a new directory off git or git/build and call it build_conf.
File scripts/build/ (right):
scripts/build/ known_missing_files = ''
could this be a list instead of a string?

I thought about whether a string was the _best_ solution, but decided that using a read() and find() was simplest and probably quickest.
scripts/build/ known_missing_files_file = a

Again, I'm assuming that this is changing from a simple string for the filename to a list? Strikes me we don't want lots of lists of missing files we can pass to the script - that'll just get confusing - I'd suggest just using a single file for any call.
scripts/build/ missing_files = open
(known_missing_files_file, 'r')
missing_Files = open(...).readlines()

then you don't need the next two lines.

So with:

string = open("filename").read()

You don't need the close() ?
scripts/build/ if known_missing_files.find
(include_name) == -1:
if include_name in known_missing_files:

Depending on whether we do use lists...

lilypond-devel mailing list

Phil Holmes

reply via email to

[Prev in Thread] Current Thread [Next in Thread]