|
From: | percival . music . ca |
Subject: | Re: MIDI: intelligently combine overlapping notes. (issue4520050) |
Date: | Wed, 25 May 2011 10:32:55 +0000 |
LGTM http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly File input/regression/midi-unisons.ly (right): http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly#newcode6 input/regression/midi-unisons.ly:6: @code{timidity -idvvv file.midi |grep Midi} to see midi events." I could kiss you for giving this exact command-line way to test midi events! http://codereview.appspot.com/4520050/diff/16001/input/regression/midi-unisons.ly#newcode18 input/regression/midi-unisons.ly:18: \midi {} technically these two lines should be indented with two spaces, but it doesn't really matter in the regtests. http://codereview.appspot.com/4520050/
[Prev in Thread] | Current Thread | [Next in Thread] |