Re: ambitus: special handling of small ambits' lines (issue4609041)

[karin . hoethker]

Hi Janek,

the description explains clearly how to use the parameters gap and woot.
So, it is a good starting point to understanding the scheme code that
follows.

> I added a parameter which controlls this, but no reasonable name for
it
> (and for some intermediate stages in the code) comes to my mind.
> Any suggestions to what should i change "woot" and "unwooted"?

What about "gap-adjustment-strength" or "gap-optimization-strength"?
- "gap" should be contained in the name, since that is the quantity
changed by woot
- "adjustment" because the gap is optimized
- "strength", because the value ranges between 0 and 1 (as opposed to
boolean)


> Yes, the quanting stays the same.

I couldn't find the verb "to quant" in a dictionary. Is it short for
"to quantize"? If so, it might be clearer to change the description in
output-lib.scm.

Finally, I tested the gap adjustment for several intervals. For a fifth:

\new Staff \with { \consists Ambitus_engraver } {
    c' g'
}

the bottom of the ambitus line is very close to the lower note in the
default case. Is this on purpose? I would expect the ambitus line to be
more or less centered between note heads.

hope this helps,
Karin




http://codereview.appspot.com/4609041/