|
From: | Phil Holmes |
Subject: | Re: Add feta-flags to build system (issue4662055) |
Date: | Sat, 25 Jun 2011 21:21:29 +0100 |
Cc: <address@hidden>; <address@hidden> Sent: Saturday, June 25, 2011 7:42 PM Subject: Re: Add feta-flags to build system (issue4662055)
LGTM - is there any way to get this in a pixel comparator w/ the previous flags just to be certain that it doesn't cause any problems to the flags. The last time I reviewed a flag-related patch, I gave it the green light only to find that I was failing to see some slight but important variations.
The simplest way I know would be to get a mingw version and send it to me. If that's not possible I'd have to try to find a way to use an Ubuntu version with my comparator - but I think that would be quite a bit of work.
-- Phil Holmes
[Prev in Thread] | Current Thread | [Next in Thread] |