[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Modify chord-name-engraver to call capo-handler (issue4800051)

From: Wols Lists
Subject: Re: Modify chord-name-engraver to call capo-handler (issue4800051)
Date: Tue, 02 Aug 2011 22:02:23 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110713 Lightning/1.0b3pre Thunderbird/3.1.10

On 02/08/11 21:24, address@hidden wrote:
> File Documentation/notation/chords.itely (right):
> Documentation/notation/chords.itely:516: In make-pitch, leave the first
> argument at 0, the second argument is the
> A bit of syntactic sugar would OK here.  Since it's now possible to pass
> pitches as arguments to music functions, it would be nice to have a
> \capo function which doesn't require users to wrestle with
> ly:make-pitch.
That's already been posted to lily-frogs for review, if you would care
to take a look. It contains a bit too much pseudo-code and "how do I do
this" comments for my liking, which is why I didn't want to post it
anywhere else ... :-)

Basically, the idea is you put "\capoKey A" after "\key C \major" or
whatever, and it does the rest, working out the transposition, the fret,
and printing the appropriate text, ie "Capo 3 (A)" at the start of the

> File lily/ (right):
> lily/ SCM capo_proc = ly_lily_module_constant
> ("capo-handler");
> While this gets round the duplication in formatter functions, it hides
> the actual context property which does the formatting (and you won't
> find another instance of ly_lily_module_constant () used in this way).
> I still think the minor duplication is preferable.


And if somebody creates a new chord-formatter and forgets it, some poor
user is going to get bitten by the mysterious failure of the capo
function :-(

reply via email to

[Prev in Thread] Current Thread [Next in Thread]