[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Get rid of some compiler warnings (issue4854049)

From: Carl . D . Sorensen
Subject: Get rid of some compiler warnings (issue4854049)
Date: Tue, 09 Aug 2011 21:20:29 +0000

LGTM, with a few comments.


File lily/ (right):
lily/ buildings_ = internal_build_skyline (&boxes,
horizon_padding, a, UP);
What if instead of changing X_AXIS to a in line 417, we checked a to see
if it were equal to X_AXIS and issued a warning (or maybe a programming

Note that we have UP hardcoded as well, so at this point I don't think
we ought to remove the hardcoding on only the a.
File ly/ (right):
ly/ (_i "Scale @var{arg} up by a factor of
I think the whole expression 2^... should be wrapped in a @code{} block.

Also, should this be part of the warning fix patch?
File lily/ (right):
Lyric_combine_music_iterator::check_new_context (SCM /*sev*/)
Why not /*SCM sev*/ with a FIXME?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]