[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Get rid of some compiler warnings (issue4854049)

From: percival . music . ca
Subject: Re: Get rid of some compiler warnings (issue4854049)
Date: Wed, 10 Aug 2011 05:19:42 +0000
File input/regression/ (right):
input/regression/ \paper {
#(set-paper-size "a6") }
is this part of the compiler warnings patch?
File lily/ (right):
lily/ if (n1 < 0 || n2 < 0 || unsigned(n1) >=
note_heads.size ())
could we also get some parentheses around the cases?  If/when we add
we'll get warnings about those anyway.

Also, my initial preference would be to case note_heads.size() to int
rather than n1 to unsigned, but I confess that I can't think of an
actual rule as to why that is.  It's just from seeing things done that
way more often than the alternative.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]