[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

From: Carl . D . Sorensen
Subject: Re: T1349 - Fix load order for running with Guile V2 (issue4849054)
Date: Thu, 11 Aug 2011 00:01:29 +0000

Thanks for tackling this.

Your tab to space conversion on lily.scm has lots of errors.  Please
either revert those changes or get them right.

markup.scm should continue to use interval-length, rather than car.


File scm/lily.scm (right):
scm/lily.scm:229: (ly:message
Indent is wrong here -- should align with test, not with if.
scm/lily.scm:272: (ly:get-option 'trace-memory-frequency)
Indentation needs to move in one parenthesis level on this line and
scm/lily.scm:294: (ly:progress "[~A" file-name))
indent one more level
scm/lily.scm:296: (ly:error (_ "cannot find: ~A") x))
indent one more level
scm/lily.scm:299: (ly:progress "]\n"))))
indent one more level
scm/lily.scm:303: (vector-ref (uname) 0) char-set:letter+digit)))
needs to be indented beyond string-tokenize
scm/lily.scm:305: (member (string-downcase (cadr platform)) '("95" "98"
Indent one more level
File scm/markup.scm (right):
scm/markup.scm:74: (xoff (+ space (cdr (ly:stencil-extent head X)))))
Please keep this interval-length, because it isolates the function from
the data representation.

If we need to split lily-library.scm so we can load it earlier, we
should do so.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]