[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: T1349 - Fix load order for running with Guile V2 (issue4849054)
From: |
n . puttock |
Subject: |
Re: T1349 - Fix load order for running with Guile V2 (issue4849054) |
Date: |
Thu, 11 Aug 2011 20:40:45 +0000 |
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm
File scm/lily.scm (right):
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode324
scm/lily.scm:324: (> file-name-length 2)
tab->space conversion has broken indentation here (and lines below)
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode408
scm/lily.scm:408: ;; Library definitions, need to be at the head of the
list
this is a top-level comment, so you can't indent it two spaces
(alternatively, put it inside the define)
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode412
scm/lily.scm:412: ;; Files containing definitions used later by other
files later in load
top-level comment; fix indent
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode415
scm/lily.scm:415: ;; Main body of files to be loaded
top-level comment; fix indent
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode467
scm/lily.scm:467: ;; Files to be loaded last
top-level comment; fix indent
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode476
scm/lily.scm:476: init-scheme-files-used
indent:
(append init-scheme-files-lib
init-scheme-files-used
...)
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode638
scm/lily.scm:638: (lambda (a b)
tab->space conversion has broken indentation here (and lines below)
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode770
scm/lily.scm:770: 'log-file (format #f "~a-~a"
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode779
scm/lily.scm:779: (acons (list-element-index joblist pid)
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode795
scm/lily.scm:795: job (status:term-sig state)))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode802
scm/lily.scm:802: (map car errors)))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode806
scm/lily.scm:806: '(0 0) (profile-measurements)))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode817
scm/lily.scm:817: (string-contains f "lilypond")))))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode831
scm/lily.scm:831: (format #f "~a.log" (ly:get-option 'log-file))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode840
scm/lily.scm:840: (profile-measurements)
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode855
scm/lily.scm:855: (mtrace:dump-results base)))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/lily.scm#newcode857
scm/lily.scm:857: (ly:set-option (car s) (cdr s)))
restore indentation
http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm
File scm/markup.scm (left):
http://codereview.appspot.com/4849054/diff/17001/scm/markup.scm#oldcode239
scm/markup.scm:239: (defmacro*-public markup (#:rest body)
move this for consistency?
http://codereview.appspot.com/4849054/
- T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/10
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), Carl . D . Sorensen, 2011/08/10
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), n . puttock, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054),
n . puttock <=
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11
- Re: T1349 - Fix load order for running with Guile V2 (issue4849054), ianhulin44, 2011/08/11