Re: Doc: NR Section on Upbeats made clearer (issue 5520056)

[pkx166h]

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1350
Documentation/notation/rhythms.itely:1350: partial measure @emph{before}
the start of the next full measure.
On 2012/01/10 22:23:29, janek wrote:
> What about
> "where @address@hidden is the duration that will be added before
the first
> measure.  In other words, it is the @emph{remaining} length of the
partial
> measure @emph{before} the start of the first full measure."
> ?

Because partials can occur in any part of the score. So saying 'first'
measure is not correct. It could be the 200th measure. I know we say
don't use \partials in the beginning of a piece but we can and they work
and if I have different \score constructs in my score it still might not
be the 'first' measure. So we need to be boringly, technically accurate.

Also if you have to write 'in other words' in a document then you
probably haven't articulated clearly enough what you should have said in
the first place.

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1353
Documentation/notation/rhythms.itely:1353: \time 6/8
On 2012/01/09 05:08:58, Graham Percival wrote:
> huh?!  why is this easier to understand than \partial 4 ?

This specific example no, but because I had changed the first example
and wanted to keep it the same throughout... anyway I have changed the
time sig so it makes more sense (I think).

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1355
Documentation/notation/rhythms.itely:1355: e8 | a4 c8 b[ c b] |
On 2012/01/09 05:08:58, Graham Percival wrote:
> what on earth does manual beaming have to do with a \partial?  How
does that
> improve this example?

Done.

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1358
Documentation/notation/rhythms.itely:1358: The partial @var{duration}
can be any value less than a full measure:
On 2012/01/10 22:23:29, janek wrote:
> I'm not sure about "partial duration" thing.

> But i like the "value" part.

Reworded slightly.

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1358
Documentation/notation/rhythms.itely:1358: The partial @var{duration}
can be any value less than a full measure:
On 2012/01/10 22:23:29, janek wrote:
> I'm not sure about "partial duration" thing.

> But i like the "value" part.

changed this slightly.

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1363
Documentation/notation/rhythms.itely:1363: r4 e8 | a4 c8 b[ c b] |
On 2012/01/10 22:23:29, janek wrote:
> i think original example was better because it showed use of 8*3
construct.

I disagree. We can show that construct elsewhere, that has nothing to do
with partials. I wanted to remove that mutiplyer from the examples (just
because was can do it doesn't always mean we should do it).

Maybe 6/8 time is a time sig to use in this case.

If I were using 3/4 and wanted a whole note in my partial I would use 4
not 8*2 - heck I could use 16*4 and still be right.

http://codereview.appspot.com/5520056/diff/1/Documentation/notation/rhythms.itely#newcode1366
Documentation/notation/rhythms.itely:1366: The @code{\partial
@var{duration}} can also be written as;
On 2012/01/09 12:58:58, Neil Puttock wrote:
> On 2012/01/09 05:08:58, Graham Percival wrote:
> > if this was true, then surely there would be no difference between
\partial
> and
> > \set blah  after the piece had begun.  However, the @knownissues
claims that
> you
> > should only use \partial in the beginning.

> It's almost the same.  The main difference is that \partial uses an
iterator to
> set measurePosition.  It ensures grace notes don't mess up the timing
(which can
> affect beaming) and allows \displayMusic to pick up the correct
duration.

Well I have asked on this tracker issue why we use

\set Timing.measurePosition address@hidden

as an example here because we never actually use it literally.

#(ly:make-moment -1 4) != -duration

#(ly:make-moment -1 4) == #(ly:make-moment {var1} {var2})
where var1 is etc. etc.

Hence why I asked if this is the only construct we can use for \set
Timing.measurePosition (at least in this case) in which case we can
remove this whole para and just leave the @knownissue.

http://codereview.appspot.com/5520056/