[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Glyphs for Kievan Notation (issue 4951062)
From: |
janek . lilypond |
Subject: |
Re: Glyphs for Kievan Notation (issue 4951062) |
Date: |
Tue, 24 Jan 2012 22:43:04 +0000 |
only one change left.
On 2012/01/23 01:02:13, aleksandr.andreev wrote:
Regarding comments by Jan:
>> I guess it should be 2.5 staff_space or something
I changed the depth and height parameters as you suggested.
However, I do not see any difference, in the reg tests
or in my test files. Are we sure that the entire glyph
has to fit within the char_box, including the "stem"?
Yes. There is a difference, compare the position of "kievan" markups in
pdfs attached in the last 2 comments in tracker issue
http://code.google.com/p/lilypond/issues/detail?id=1873#c22
You've forgotten about one char_box, see below.
On 2012/01/24 15:39:22, aleksandr.andreev wrote:
When I go to make the regression tests, I get the following
error message: [...]
I've run make and regtests from scratch on a freshly-updated source.
Regtests seem fine to me (only some differences in logs, looking
harmless).
http://codereview.appspot.com/4951062/diff/110002/mf/parmesan-noteheads.mf
File mf/parmesan-noteheads.mf (right):
http://codereview.appspot.com/4951062/diff/110002/mf/parmesan-noteheads.mf#newcode1813
mf/parmesan-noteheads.mf:1813: set_char_box (0, 1.02 staff_space#, 0.37
staff_space#, 0.40 staff_space#);
this bounding box is still too small. The third number should be 2.6
staff_space#
http://codereview.appspot.com/4951062/
- Re: Glyphs for Kievan Notation (issue 4951062), (continued)
- Re: Glyphs for Kievan Notation (issue 4951062), aleksandr . andreev, 2012/01/12
- Re: Glyphs for Kievan Notation (issue 4951062), janek . lilypond, 2012/01/17
- Re: Glyphs for Kievan Notation (issue 4951062), n . puttock, 2012/01/18
- Re: Glyphs for Kievan Notation (issue 4951062), bordage . bertrand, 2012/01/22
- Re: Glyphs for Kievan Notation (issue 4951062), aleksandr . andreev, 2012/01/22
- Re: Glyphs for Kievan Notation (issue 4951062), aleksandr . andreev, 2012/01/24
- Re: Glyphs for Kievan Notation (issue 4951062), julien . rioux, 2012/01/24
- Re: Glyphs for Kievan Notation (issue 4951062),
janek . lilypond <=
- Re: Glyphs for Kievan Notation (issue 4951062), aleksandr . andreev, 2012/01/24
- Re: Glyphs for Kievan Notation (issue 4951062), julien . rioux, 2012/01/24