[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Axis group interface ignores column rank for pure-from-neighbor-inte

From: k-ohara5a5a
Subject: Re: Axis group interface ignores column rank for pure-from-neighbor-interface (issue 5843063)
Date: Wed, 21 Mar 2012 05:58:42 +0000

Yippee; no more grobs getting their pure_height from their neighbors!

Don't forget to update the commit message.  You can also "edit this
issue" to update the title and summary here on Rietveld.
File input/regression/
input/regression/ \version
The title makes less sense now.  "" ?
input/regression/ texidoc
= "@code{axis-group-interface::pure-height} does not take spanned
The description no longer fits.  Maybe
"empty measures do not confuse SpanBarStub.  These lyrics should remain
clear of the span bars."
File lily/ (right):
lily/ cache_pure_height (Grob::pure_height (this, 0,
This commit :;a=commitdiff;h=9fe7859a8592a080413b744e3768db41059dbfe3
depended on having 'start' and 'end' passed through, so we should put
this back.

Caching in this way assumes that the pure_height of an Item is
independent of where the line-breaks are.

Anything that gets pure_height from its neighbors would break that
assumption, but now it seems there are no such Items, as they all use
pure-from-neighbors-interface to set their extra-spacing-height.

Tied accidentals break that assumption as well, but that's not our
fault.  I'll write a cautionary comment in a separate commit.
File scm/define-grobs.scm (right):
scm/define-grobs.scm:1883: (Y-extent . (1 . -1))
I suggest (Y-extent . #f)
because (1 . -1) looks so much like (-1 . 1), and it also makes
suspicious people like me think it is an uncommented magic number.
File scm/output-lib.scm (right):
scm/output-lib.scm:437: (let* ((height (ly:grob-pure-height grob grob 0
The C code uses INT_MAX to represent the end of the whole score, so it
would be nice to use the same here, if possible.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]