[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Lilypond patchy and other Lilypond problems

From: James
Subject: Re: Lilypond patchy and other Lilypond problems
Date: Sun, 29 Apr 2012 01:43:15 +0100


On 28 April 2012 23:18, Łukasz Czerwiński <address@hidden> wrote:
> On 28 April 2012 10:30, Graham Percival <address@hidden> wrote:
>> As long as I'm not personally playing nursemaid for people
>> who don't run the basic tests
> It seems that the whole talk about running tests is only because of me not
> running them before uploading my first patches because I didn't know that I
> should do it. Do you have any other examples of committers that did not run
> tests? I guess that you don't have.

Oh yes there have been lots. I know because I used to apply patches
and run the tests manually.

The most common problems were devs 'forget' they have a 'dirty' branch
and upload their patches based on their own branches not master. So
the patch doesn't apply. (comment #1)

This can cause hunk failures or make problems (where someone has
changed a file but not added it to their commit).

This doesn't mean they didn't run tests, necessarily, but it means
they didn't run tests against current master.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]