lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: line_count fixes (issue 6211047)


From: k-ohara5a5a
Subject: Re: line_count fixes (issue 6211047)
Date: Tue, 15 May 2012 07:24:30 +0000

Pál, I'm not on a system today that can compile Lilypond so I cannot
look at the points you asked about, at least not today.  I hope someone
else can.


http://codereview.appspot.com/6211047/diff/1/lily/beam.cc
File lily/beam.cc (right):

http://codereview.appspot.com/6211047/diff/1/lily/beam.cc#newcode1282
lily/beam.cc:1282: staff_span *= 0.5 / staff_space;
I agree that you do not want the division in this case.
I find that I often need to test by hand with an \override staff-space
whenever I touch code with these conversions.  I've been thinking of
adding a couple regression tests that have this override, but it seems
they need to cover quite a lot.

http://codereview.appspot.com/6211047/

reply via email to

[Prev in Thread] Current Thread [Next in Thread]