[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Doc: NR typo for Midi Instuments used in example (issue 6940064)
From: |
dak |
Subject: |
Re: Doc: NR typo for Midi Instuments used in example (issue 6940064) |
Date: |
Mon, 17 Dec 2012 17:38:46 +0000 |
On 2012/12/17 17:21:39, email_philholmes.net wrote:
----- Original Message -----
From: <mailto:address@hidden>
To: <address@hidden>; <mailto:address@hidden>
Cc: <address@hidden>;
<mailto:address@hidden>
Sent: Monday, December 17, 2012 11:27 AM
Subject: Re: Doc: NR typo for Midi Instuments used in example (issue
6940064)
> I'd prefer it if the MIDI instruments in this patch
> were not capitalised, in order to be consistent with
> the rest of the documentation and in particular with
> Appendix A6. I've no objection in principle to
> capitalising the names, but it should be done
> consistently throughout the documentation as a
> separate patch.
>
> Otherwise LGTM
>
> Trevor
>
>
> https://codereview.appspot.com/6940064/
I definitely think they should all be capitalised. See, for example,
http://www.midi.org/techspecs/gm1sound.php
It is not a matter of preference. The definitions in scm/midi.scm
(instrument-names-alist) are lowercase, and LilyPond uses assoc-get in
midi-program for looking them up, which is case-sensitive.
The capitalized versions just won't work for that reason.
https://codereview.appspot.com/6940064/
- Doc: NR typo for Midi Instuments used in example (issue 6940064), PhilEHolmes, 2012/12/16
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), tdanielsmusic, 2012/12/17
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064),
dak <=
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), tdanielsmusic, 2012/12/17
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), pkx166h, 2012/12/17
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), pkx166h, 2012/12/17
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), tdanielsmusic, 2012/12/17
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), tdanielsmusic, 2012/12/17
- Re: Doc: NR typo for Midi Instuments used in example (issue 6940064), graham, 2012/12/21