Re: Markup, page-ref: do not backspace; issue 3334 (issue 8639045)

[k-ohara5a5a]

On 2013/04/27 05:38:12, dak wrote:
> On 2013/04/27 05:29:48, Keith wrote:
> > (In version 2.16, \hspace sees the global 'word-space' and corrects
for it
> > whether it locally effective or not, closing the gap in the first
line, "Page3
> > contains".)

> Issue 1100 has only been fixed in version 2.17.16.  Maybe it is just
then that
> the problem surfaced?

Confirmed.  The patch for issue 1100 explicitly passes the outer-scope
'word-space' to any functions inside.   That was the moment when
\page-ref started to misplace the page-number.

That patch also means that the \hspace in the first line of
  \markup \concat { "A" \hspace #0 "B" "C"}
  \markup { "A" \hspace #0 "B" "C"}
thinks it needs to cancel a word-space and will backspace over the A.
That symptom is probably a sign that it was unwise to have \hspace try
to correct for inter-word space.

Avoiding \concat in this function (\page-ref)is still the right thing to
do, and now we know why.

https://codereview.appspot.com/8639045/