Re: Markup, page-ref: do not backspace; issue 3334 (issue 8639045)

[k-ohara5a5a]

https://codereview.appspot.com/8639045/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (left):

https://codereview.appspot.com/8639045/diff/1/scm/define-markup-commands.scm#oldcode4083
scm/define-markup-commands.scm:4083: (markup #:concat (#:hspace gap
page-markup)))))))
On 2013/04/26 06:56:34, Keith wrote:
> I have not yet figured out how it worked
> correctly in version 2.14

In version 2.14, \hspace sees the current value of 'word-space'
effective in the local construction :
  \markup { "Page" \concat {\hspace #0 "3"} "contains"}  %0.0
  \markup { "Page" {\hspace #0 "3"} "contains"}          %0.6

In version 2.14, \hspace cancels the space, either 0 or 0.6, between
itself and "3" so both lines above have the same end-result.

(In version 2.16, \hspace sees the global 'word-space' and corrects for
it whether it locally effective or not, closing the gap in the first
line, "Page3 contains".)

Thus the \concat that I am removing has not been needed since version
2.14 or earlier.

LGTM

https://codereview.appspot.com/8639045/