[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Uses single algorithm for side-position spacing. (issue 6827072)
|
From: |
k-ohara5a5a |
|
Subject: |
Re: Uses single algorithm for side-position spacing. (issue 6827072) |
|
Date: |
Sat, 17 Aug 2013 07:02:55 +0000 |
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc
File lily/side-position-interface.cc (right):
https://codereview.appspot.com/6827072/diff/38003/lily/side-position-interface.cc#newcode194
lily/side-position-interface.cc:194: common[ax] =
common_refpoint_of_array (support,
One recurring problem, present in the old code but appearing more with
the new, is that the common_refpoint of a set of 'support' that crosses
staves could be the overall VerticalAlignment.
When the first attempt to estimate the space required by staves
estimates the position of something with 'support' on multiple staves,
the common_refpoint is the VerticalAlignment, and the call to
maybe_pure_coordinate() on line 234 tries to estimate the position of
our staff in the VerticalAlignment, which is what we were in the middle
of doing.
programming error: cyclic dependency: calculation-in-progress
encountered for #'adjacent-pure-heights (VerticalAxisGroup)
https://codereview.appspot.com/6827072/