[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: stencil-integral: use box extents specified in markup; issue 3255 (i
|
From: |
k-ohara5a5a |
|
Subject: |
Re: stencil-integral: use box extents specified in markup; issue 3255 (issue 9295044) |
|
Date: |
Fri, 30 Aug 2013 02:55:01 +0000 |
Untangling the stencil regressions.
The commit that made skylines from stencils (issue 2148) omitted
space-reservations for stencils that:
+ are not drawn (\transparent)
+ have unknown contents until after layout (\page-ref and similar) or
+ had their space reservation modified (\pad-around and similar).
It makes sense to put information to restore these space-reservations in
the stencil-expression, because that is where the skyline-building code
looks for them.
We could encode the information in the stencil expression as:
1) a 'with-dimensions primitive with box-dimensions, to be read by the
skyline code to restore the former behavior (this patch)
2) a 'transparent primitive with a stencil subexpression, to be read by
the skyline code but not printed
(http://codereview.appspot.com/13416044/)
Both work for me. Supposing for the moment that plan (2) meets
resistance, does this code for plan (1) look good?
https://codereview.appspot.com/9295044/