[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 3286: add single-C time signature style (issue 164830043 by ni

From: Dan Eble
Subject: Re: Issue 3286: add single-C time signature style (issue 164830043 by nine.fierce.ballads <at>
Date: Sun, 2 Nov 2014 21:11:58 -0500

On Nov 2, 2014, at 14:52 , Keith OHara <address@hidden> wrote:
> The current code has some logic to choose a glyph timesig.C34 if we 
> set style=C in 3/4 time, but it seems that code is disabled by complex
> logic.  Cleaning that up, as part of moving toward scheme markup,
> would be nice.

I followed everything you said except this, maybe because of the sudden mention 
of 3/4.  Are you implying that changing the “complex logic" to 

  1. if there is a glyph of the right name, use it
  2. otherwise, fall back on numbered style

would be a good idea? I was considering that.

I’ve got a working Scheme implementation now which should allow a user to 
associate a new style name with a procedure that converts a fraction into a 
markup.  That seems like a convenient way to support the double-C time 
signatures without building them in.

I should polish it a little before posting a review.  I’m also concerned that 
there isn’t enough regression test coverage of neomensural and mensural styles, 
so I’ll probably write and submit those separately first.  (Wish I had noticed 
a week ago, but at least nobody’s clamoring for this change.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]