[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Docs: clean up after \relative conversion (issue 239250043 by addres
|
From: |
dak |
|
Subject: |
Re: Docs: clean up after \relative conversion (issue 239250043 by address@hidden) |
|
Date: |
Fri, 29 May 2015 08:35:06 +0000 |
Will presently upload a diff incorporating the work of Keith after
applying the points made in review.
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (left):
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely#oldcode1184
Documentation/learning/common-notation.itely:1184: \partial 4
On 2015/05/26 16:21:47, dak wrote:
Ok, looks like \partial has not been caught by my patterns. I can try
changing
the patterns, reverting, rebasing, etc. It will not be just the
learning
manual.
Done.
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (right):
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/common-notation.itely#newcode1514
Documentation/learning/common-notation.itely:1514: will not be part of
the relative music:
On 2015/05/26 16:21:47, dak wrote:
not be part -> not affect the octaves
Done.
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1013
Documentation/learning/fundamental.itely:1013: \voiceOne
On 2015/05/26 16:21:47, dak wrote:
Here the \voiceXxx commands. I think I can add them to the script but
it's sort
of diminuishing returns.
Done.
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1207
Documentation/learning/fundamental.itely:1207: \autoBeamOff
On 2015/05/26 16:21:47, dak wrote:
Huh. So many "harmless" commands to take care off. Probably also
just a single
command.
Done.
https://codereview.appspot.com/239250043/diff/20001/Documentation/learning/fundamental.itely#newcode1729
Documentation/learning/fundamental.itely:1729: \set Staff.instrumentName
= #"Soprano"
On 2015/05/26 16:21:47, dak wrote:
Ok, that's the kind of complexity I don't want to parse automatically.
Well, so I did parse it automatically. I remembered that I had a
pattern called "matcharg" in python/convertrules.py that worked for the
right side of the assignment.
https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/pitches.itely
File Documentation/notation/pitches.itely (right):
https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/pitches.itely#newcode303
Documentation/notation/pitches.itely:303: @code{\relative} is
interpreted just the same as
On 2015/05/26 16:21:47, dak wrote:
This change does not make sense, actually. \relative f needs to stay
here or
the sentence becomes pointless.
Done.
https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
https://codereview.appspot.com/239250043/diff/20001/Documentation/notation/simultaneous.itely#newcode219
Documentation/notation/simultaneous.itely:219: @c Without \new Voice,
implicit voice creation does the dumbest thing.
On 2015/05/26 16:21:47, dak wrote:
Actually, I think that this comment is no longer accurate, so maybe
the \new
Voice is now expendible.
Done.
https://codereview.appspot.com/239250043/