Re: Allure and git-cl troubleshooting

[Phil Holmes]

----- Original Message ----- 
From: "James Lowe" <address@hidden>
To: "Phil Holmes" <address@hidden>; "David Kastrup" <address@hidden>
Cc: "lilypond-devel" <address@hidden>; "Trevor Daniels" 
<address@hidden>
Sent: Monday, November 02, 2015 6:11 PM
Subject: Re: Allure and git-cl troubleshooting


> On 02/11/15 15:40, Phil Holmes wrote:
> > ----- Original Message ----- From: "Phil Holmes" <address@hidden>
> > To: "David Kastrup" <address@hidden>
> > Cc: "lilypond-devel" <address@hidden>; "Trevor Daniels"
> > <address@hidden>
> > Sent: Monday, November 02, 2015 1:41 PM
> > Subject: Re: Allure and git-cl troubleshooting
> >
> >
> > > ----- Original Message ----- From: "David Kastrup" <address@hidden>
> > > To: "Phil Holmes" <address@hidden>
> > > Cc: "Trevor Daniels" <address@hidden>; "Paul Morris"
> > > <address@hidden>; "lilypond-devel" <address@hidden>
> > > Sent: Sunday, November 01, 2015 6:06 PM
> > > Subject: Re: Allure and git-cl troubleshooting
> > >
> > >
> > > > "Phil Holmes" <address@hidden> writes:
> > > >
> > > > > Turns out it is nothing to do with Allura: it's the way Rietveld uses
> > > > > Google for authentication.  See
> > > > > https://developers.google.com/identity/protocols/AuthForInstalledApps.
> > > > > Further
> > > > > thanks to Google for this.
> > > > >
> > > > > Question is: should I look into how to fix it, or is there a way to
> > > > > ask the Rietveld team to fix upload.py and we wait for them?
> > > >
> > > > I think they fixed it a long time ago but nobody bothered copying it
> > > > into our git-cl copy yet.
> > > >
> > > > --
> > > > David Kastrup
> > >
> > >
> > > Don't think it's a case of "nobody bothered", rather "nobody knew".
> > > I'll have a look see what has been done.
> > >
> > > --
> > > Phil Holmes
> >
> >
> > I've pushed an updated version to github.  Please all - pull this
> > updated version of git-cl and let me know how you get on.
>
> Thank you Mr Holmes. That looks like it has done the trick.
>
> Out of interest do you know what the upload.py 'command' (in terms of
> it's construction with the different possible switches) is being used?
> So that if git-cl breaks again I can at least upload patches to rietveld
> and then manually update Allura.

Adding a print statement to print out upload_args gives this:

['--assume_yes', '--server', 'codereview.appspot.com', '--cc', 
'address@hidden', '--issue', '269820043', '--title', 'testy', 
'--message', 'testy', '--oauth2']

I used the word 'testy' for the description of the patch set...

Think it's fairly simple to parse that into a command line.

--
Phil Holmes