Re: Added property non-default to KeySignature (issue 300840043 by address@hidden)

[panteck]

On 2016/05/30 05:09:54, dak wrote:
> On 2016/05/29 21:44:42, panteck wrote:
> > On 2016/05/29 20:09:52, dak wrote:
> > > On 2016/05/29 20:03:03, panteck wrote:
> > > > On 2016/05/29 19:03:56, dak wrote:
> > > > > On 2016/05/29 18:17:58, panteck wrote:
> > > > > > On 2016/05/29 17:39:39, dak wrote:
> > > > >
> > > > > > > Which git-cl are you using?  The one used by LilyPond puts
up an
> issue
> > > > > > (assuming
> > > > > > > correct configuration and pressing ENTER when asked for an
issue
> > > number).
> > > > > >
> > > > > > I'm assuming newest - I did a git pull prior in the git-cl
folder
> prior
> > to
> > > > > > running it.  That's not to say I didn't screw up something
else along
> > the
> > > > way.
> > > > >
> > > > > Which repository?
> > > >
> > > > git://github.com/gperciva/git-cl.git
> > >
> > > Ok, that's correct.  Sorry for the noise.  What does
> > >
> > > git cl status
> > >
> > > state in your LilyPond work directory?
> >
> > Branches associated with reviews:
> >      dev/local_working: None
> >                 master: 300840043
> >
> > Current branch: master
> > Tracker issue: None
> > Rietveld issue: 300840043 (https://codereview.appspot.com/300840043)
> > Issue description:
> >   Added property non-default to KeySignature Added the property non-
> >   default to the KeySignature grob, and updated the grob definition
to
> >   indicate that it works for both Clefs and KeySignatures now.

> Well, be sure to disassociate your master branch with this issue
before your
> next submission or it will end up in the same place.  You should
submit from a
> branch of its own.  Anyway, I can only guess that your command did not
complete,
> either because you did not answer the prompt for the issue number or
it wasn't
> able to contact Sourceforge successfully.

Are you recommending that I close this issue, apply my patch to a
development branch in git, and try again?

https://codereview.appspot.com/300840043/