|
| From: | simon . albrecht |
| Subject: | Re: Optional fraction after \afterGrace command (issue 304200043 by address@hidden) |
| Date: | Sun, 24 Jul 2016 15:59:35 -0700 |
LGTM.
https://codereview.appspot.com/304200043/diff/20001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/304200043/diff/20001/Documentation/notation/rhythms.itely#newcode3436
Documentation/notation/rhythms.itely:3436: the length of the main note.
The default is set as
The wording feels odd to me. Maybe:
This will put the grace notes after some space, equivalent
to a fraction of the duration of the main note.
?
https://codereview.appspot.com/304200043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/304200043/diff/20001/ly/music-functions-init.ly#newcode59
ly/music-functions-init.ly:59: afterGraceFraction = 6/8
What would be the point of 6/8 instead of 3/4?
https://codereview.appspot.com/304200043/diff/20001/ly/music-functions-init.ly#newcode67
ly/music-functions-init.ly:67: @code{afterGraceFraction} which has a
default value of @code{6/8}.")
(Same fraction as above.)
https://codereview.appspot.com/304200043/
| [Prev in Thread] | Current Thread | [Next in Thread] |