|
From: | ht . lilypond . development |
Subject: | Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by address@hidden) |
Date: | Thu, 04 Aug 2016 14:23:25 -0700 |
https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc File lily/dynamic-performer.cc (right): https://codereview.appspot.com/308890043/diff/1/lily/dynamic-performer.cc#newcode412 lily/dynamic-performer.cc:412: volume = equalize_volume (Audio_span_dynamic::DEFAULT_VOLUME); I keep wondering whether this assignment is intended to be kept identical to the way "volume" is initialized above in the "first time only" case (before this patch, the behavior would be the same, but now it's different), and why the "first time" case needs to be handled separately since the control flow will end up in the if block starting at line 405 even in that case... https://codereview.appspot.com/308890043/
[Prev in Thread] | Current Thread | [Next in Thread] |