[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: adding a snippet to a patch

From: Mark Knoop
Subject: Re: adding a snippet to a patch
Date: Wed, 11 Jan 2017 08:08:07 +0000

At 15:51 on 09 Jan 2017, David Nalesnik wrote:
>On Mon, Jan 9, 2017 at 2:00 PM, David Nalesnik
><address@hidden> wrote:
>> Hi,
>> I'm adding a snippet to a patch dealing with hairpins, and I'm not
>> sure what I need to do.
>> I've added the snippet to Documentation/snippets/new.
>> Do I then need to run scripts/auxiliar/ and add the
>> resulting files to my patch for upload to Rietveld?
>> The reason I ask is that there is a snippet not my own which is
>> getting written to Documentation/snippets/ when I run the script:
>>  This leads to changes in
>> Documentation/snippets/staff-notation.snippet-list as well.
>> I don't want these changes jumbled in with my patch.  
>Looking over several older patches affecting snippets, I see that I
>should run the makelsr script and add the resulting files.
>This, however, was not done in the last patch adding a snippet:
>commit 5944d20489bb5b8e4c4907fa3b3bcae9ec275ccb
>Author: Mark Knoop <address@hidden>
>Date:   Thu Sep 8 18:56:16 2016 +0100

I suppose this is simply because I was also unsure what to do. I thought
I followed the CG for this at the time, but probably missed a step or

Mark Knoop

reply via email to

[Prev in Thread] Current Thread [Next in Thread]