[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Wed, 21 Jun 2017 06:55:24 +0200
Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)
Carl Sorensen <address@hidden> writes:
> I've been working with Charles Winston on the chord semantics GSOC project.
> I've found what I think is an obsolete piece of code in
> for (SCM s = get_music ()->get_property ("articulations");
> scm_is_pair (s); s = scm_cdr (s))
> Music *mus = unsmob<Music> (scm_car (s));
> report_event (mus);
> As far as I can see, an EventChord no longer has an 'articulations
It never had.
> instead, the articulations are stored as an 'articulations item in
All post events are stored in 'elements, not as an 'articulations item.
> Should this code be eliminated?
Have you tried running "git blame" on the passage? It leads to commit
Author: David Kastrup <address@hidden>
Date: Wed Feb 8 10:53:38 2012 +0100
Let EventChord replay articulations
and searching for the commit in the issue tracker leads to
with the code review
While LilyPond produces the same expressions as always, user code is
allowed to be more sloppy in order to simplify user-level programming.
This is quite deliberate.