[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Implementing Chord Semantics as a part of the EventChord structure, (iss
From: |
nine . fierce . ballads |
Subject: |
Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by address@hidden) |
Date: |
Thu, 06 Jul 2017 14:57:22 -0700 |
I reviewed the C++ file. I believe others are more qualified to review
the patch as a whole.
https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc
File lily/chord-name-engraver.cc (right):
https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc#newcode99
lily/chord-name-engraver.cc:99: SCM name_proc = get_property
("chordSemanticsNameFunction");
1. Should chordSemanticsNameFunction be included in the list at the
bottom of this file? (I think so.)
2. Does the type of name_proc need to be validated before passing it to
scm_call_2? (I really don't remember.)
https://codereview.appspot.com/321250043/diff/1/lily/chord-name-engraver.cc#newcode103
lily/chord-name-engraver.cc:103: // Ugh, we created a grob, now we
better populate it.
If this was not expected, then as a user, I would like to see lilypond
emit a warning.
https://codereview.appspot.com/321250043/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Implementing Chord Semantics as a part of the EventChord structure, (issue 321250043 by address@hidden),
nine . fierce . ballads <=