[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Fix a few complaints in python/convertrules.py (issue 583290043 by addre
From: |
jonas . hahnfeld |
Subject: |
Fix a few complaints in python/convertrules.py (issue 583290043 by address@hidden) |
Date: |
Wed, 08 Jan 2020 00:17:25 -0800 |
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode1774
python/convertrules.py:1774: str += "'" * (o + 1)
I agree that this is equivalent, but still very confusing. I would
propose the following which should highlight the intent:
o += 1
if o < 0:
str += ',' * (-o)
elif o > 0:
str += "'" * o
https://codereview.appspot.com/583290043/diff/557180043/python/convertrules.py#newcode3973
python/convertrules.py:3973: if re.search (r"#(banter|jazz)-chordnames",
str):
Is the change from "chord-names" to "chordnames" intentional?
https://codereview.appspot.com/583290043/
- Fix a few complaints in python/convertrules.py (issue 583290043 by address@hidden),
jonas . hahnfeld <=