[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Added transition lines for lyrics (issue 565750043 by address@hidden
From: |
davidgrant . no |
Subject: |
Re: Added transition lines for lyrics (issue 565750043 by address@hidden) |
Date: |
Wed, 25 Mar 2020 01:45:31 -0700 |
Patch description in the issue tracker has been updated.
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc
File lily/vowel-transition.cc (right):
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode37
lily/vowel-transition.cc:37: SCM num_length = me->get_property
("minimum-length");
On 2020/03/24 21:46:30, hanwenn wrote:
> num suggests a number.
>
> minimum_length ?
Done.
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode137
lily/vowel-transition.cc:137: w += -d * r->item_drul_[d]->extent
(r->item_drul_[d], X_AXIS)[-d];
On 2020/03/24 21:46:29, hanwenn wrote:
> this still looks strange, but if it's problem, it'll be contained
within the
> vowel-transition code, which is acceptable.
Acknowledged, thanks.
https://codereview.appspot.com/565750043/
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), (continued)
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/11
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/11
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/11
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/12
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), lemzwerg, 2020/03/12
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/13
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/15
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/15
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), davidgrant . no, 2020/03/20
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/24
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden),
davidgrant . no <=
- Re: Added transition lines for lyrics (issue 565750043 by address@hidden), hanwenn, 2020/03/27