Re: Define Scheme markups using define-public (issue 577720043 by address@hidden)

[Han-Wen Nienhuys]

On Sun, Mar 29, 2020 at 4:12 PM <address@hidden> wrote:
>
> On 2020/03/29 13:55:41, hanwenn wrote:
> > On 2020/03/29 13:52:48, hanwenn wrote:
> > > retain existing
> >
> > how's this? This leaves things backward compatible.
>
> Ugly and a maintenance burden since the code is used twice.  Anything
> wrong with my proposal?

I didn't understand your proposal.

> It does not have duplicate code, makes
> define-markup-command compilable (while requiring its toplevel use) and
> provides a way of doing the same consistently for module-specific rather
> than toplevel use.
>
> It sacrifices, like your proposal, non-toplevel-performance for the sake
> of compilability in Guilev2.  It's just that what the parser then uses
> is in a form that could also be used in a reasonably natural manner from
> Scheme.
>
> Should I write up a patch doing that?

Yes please.

>
> https://codereview.appspot.com/577720043/



-- 
Han-Wen Nienhuys - address@hidden - http://www.xs4all.nl/~hanwen