[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Optimize get_path_list. (issue 579570043 by address@hidden)
|
From: |
hanwenn |
|
Subject: |
Re: Optimize get_path_list. (issue 579570043 by address@hidden) |
|
Date: |
Mon, 13 Apr 2020 12:11:22 -0700 |
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc#newcode115
lily/stencil-integral.cc:115: && (SCM_EQ_P (head, ly_symbol2scm
("moveto"))
On 2020/04/13 17:50:33, dak wrote:
> SCM_EQ_P is an old deprecated macro. Use scm_is_eq instead. Same
performance.
Done.
https://codereview.appspot.com/579570043/diff/577750045/lily/stencil-integral.cc#newcode127
lily/stencil-integral.cc:127: return get_path_list (scm_cdr (l));
On 2020/04/13 17:50:33, dak wrote:
> Not caused by this patch, but this does look like something nicer
addressed by a
> loop rather than tail recursion with regard to C++ idioms.
I'm gonna pass on this for now.
https://codereview.appspot.com/579570043/