lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use vectors rather than lists for skylines. (issue 583750043 by addr


From: hanwenn
Subject: Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden)
Date: Tue, 21 Apr 2020 00:38:33 -0700

On 2020/04/18 11:38:17, Dan Eble wrote:
>
https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc
> File lily/skyline.cc (right):
> 
>
https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode75
> lily/skyline.cc:75: i.print ();
> I'm sorry, I gave you imperfect advice here because I had an iterator
on my
> mind.  Now that I see i.print(), I realize that it should be for (auto
&i : b)
> to guarantee that it uses a reference to the item rather than making a
copy of
> the item.  Again, sorry.

Thanks for the correction! It's debugging code, so either way is fine. 

https://codereview.appspot.com/583750043/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]