[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use vectors rather than lists for skylines. (issue 583750043 by addr
From: |
hanwenn |
Subject: |
Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden) |
Date: |
Tue, 21 Apr 2020 00:38:33 -0700 |
On 2020/04/18 11:38:17, Dan Eble wrote:
>
https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc
> File lily/skyline.cc (right):
>
>
https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode75
> lily/skyline.cc:75: i.print ();
> I'm sorry, I gave you imperfect advice here because I had an iterator
on my
> mind. Now that I see i.print(), I realize that it should be for (auto
&i : b)
> to guarantee that it uses a reference to the item rather than making a
copy of
> the item. Again, sorry.
Thanks for the correction! It's debugging code, so either way is fine.
https://codereview.appspot.com/583750043/
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), (continued)
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), hanwenn, 2020/04/17
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), Carl . D . Sorensen, 2020/04/17
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), jonas . hahnfeld, 2020/04/17
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), nine . fierce . ballads, 2020/04/17
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), hanwenn, 2020/04/18
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), hanwenn, 2020/04/18
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), hanwenn, 2020/04/18
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), nine . fierce . ballads, 2020/04/18
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden),
hanwenn <=
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), dak, 2020/04/21
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), nine . fierce . ballads, 2020/04/21
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), nine . fierce . ballads, 2020/04/22
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), dak, 2020/04/23
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), dak, 2020/04/23
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), jonas . hahnfeld, 2020/04/24
- Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden), hanwenn, 2020/04/24