Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden)

[hanwenn]

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc
File lily/skyline.cc (right):

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode183
lily/skyline.cc:183: vector<Building>::iterator i;
On 2020/04/24 07:08:50, hahnjo wrote:
> move into for loop and make auto

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode189
lily/skyline.cc:189: vector<Building>::iterator last = i;
On 2020/04/24 07:08:50, hahnjo wrote:
> auto

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode216
lily/skyline.cc:216: vector<Building>::const_iterator cit = scp->begin
();
On 2020/04/24 07:08:51, hahnjo wrote:
> auto (2x)

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode319
lily/skyline.cc:319: for (vector<Building>::const_iterator i =
buildings.begin ();
On 2020/04/24 07:08:51, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode565
lily/skyline.cc:565: vector<Building>::iterator end = buildings_.end ();
On 2020/04/24 07:08:50, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode574
lily/skyline.cc:574: for (vector<Building>::iterator i =
buildings_.begin (); i != end; i++)
On 2020/04/24 07:08:51, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode620
lily/skyline.cc:620: for (vector<Building>::const_iterator i =
buildings_.begin ();
On 2020/04/24 07:08:51, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode677
lily/skyline.cc:677: vector<Building>::const_iterator j =
other.buildings_.begin ();
On 2020/04/24 07:08:51, hahnjo wrote:
> auto (2x)

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode711
lily/skyline.cc:711: vector<Building>::const_iterator i;
On 2020/04/24 07:08:51, hahnjo wrote:
> move into for and auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode727
lily/skyline.cc:727: vector<Building>::const_iterator i;
On 2020/04/24 07:08:50, hahnjo wrote:
> move into for and auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode748
lily/skyline.cc:748: for (vector<Building>::const_iterator i
(buildings_.begin ());
On 2020/04/24 07:08:51, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode760
lily/skyline.cc:760: for (vector<Building>::const_reverse_iterator i
(buildings_.rbegin ());
On 2020/04/24 07:08:51, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/diff/577780043/lily/skyline.cc#newcode792
lily/skyline.cc:792: for (vector<Building>::const_iterator i
(buildings_.begin ());
On 2020/04/24 07:08:51, hahnjo wrote:
> auto or range-based for

Done.

https://codereview.appspot.com/583750043/