|
From: | jonas . hahnfeld |
Subject: | Re: Use vectors rather than lists for skylines. (issue 583750043 by address@hidden) |
Date: | Fri, 24 Apr 2020 06:04:36 -0700 |
Han-Wen, any reason not to use range-based loops in the places I pointed to in the last patch set? https://codereview.appspot.com/583750043/diff/545930043/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/583750043/diff/545930043/lily/skyline.cc#newcode184 lily/skyline.cc:184: for (vector<Building>::iterator i = buildings_.begin (); auto https://codereview.appspot.com/583750043/diff/545930043/lily/skyline.cc#newcode753 lily/skyline.cc:753: for (vector<Building>::const_reverse_iterator i (buildings_.rbegin ()); auto or rather range-based for https://codereview.appspot.com/583750043/
[Prev in Thread] | Current Thread | [Next in Thread] |