lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use a hash table for the lexer keywords (issue 549920043 by address@


From: David Kastrup
Subject: Re: Use a hash table for the lexer keywords (issue 549920043 by address@hidden)
Date: Mon, 27 Apr 2020 11:11:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Han-Wen Nienhuys <address@hidden> writes:

> On Mon, Apr 27, 2020 at 10:59 AM <address@hidden> wrote:
>> When the parser sees some \blabla it will generally first have to check
>> for a keyword and (when it has no match) afterwards for a variable with
>> that name, and a lot of those are actually music functions these days
>> that used to be keyword.
>>
>> Wouldn't it make sense to just convert \xxx into a symbol early on in
>> the lexer?  That is essentially a hash code, and we have lookups for
>> those.  It seems wasteful to use two completely different ways of
>> hashing a string in succession when we can just turn this into a symbol
>> early on and work with that instead.
>
> If you can make Bison work off SCM symbol values, be my guest.

Yo may have missed the memo, but everything passed into and out of the
parser and Lexer these days is SCM.  And for looking up a token ID from
an SCM symbol, Guile has hashtables, and we also habe Scm_hashtable.

-- 
David Kastrup



reply via email to

[Prev in Thread] Current Thread [Next in Thread]