[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use a hash table for the lexer keywords (issue 549920043 by address@

From: dak
Subject: Re: Use a hash table for the lexer keywords (issue 549920043 by address@hidden)
Date: Mon, 27 Apr 2020 04:58:11 -0700

On 2020/04/27 09:11:16, dak wrote:
> Han-Wen Nienhuys <mailto:address@hidden> writes:
> > On Mon, Apr 27, 2020 at 10:59 AM <mailto:address@hidden> wrote:
> >> When the parser sees some \blabla it will generally first have to
> >> for a keyword and (when it has no match) afterwards for a variable
> >> that name, and a lot of those are actually music functions these
> >> that used to be keyword.
> >>
> >> Wouldn't it make sense to just convert \xxx into a symbol early on
> >> the lexer?  That is essentially a hash code, and we have lookups
> >> those.  It seems wasteful to use two completely different ways of
> >> hashing a string in succession when we can just turn this into a
> >> early on and work with that instead.
> >
> > If you can make Bison work off SCM symbol values, be my guest.
> Yo may have missed the memo, but everything passed into and out of the
> parser and Lexer these days is SCM.  And for looking up a token ID
> an SCM symbol, Guile has hashtables, and we also habe Scm_hashtable.
> -- 
> David Kastrup

Tracker issue: 5946
Rietveld issue: 577840053 (
Issue description:
  Use Scheme_hash_table for keyword handling

reply via email to

[Prev in Thread] Current Thread [Next in Thread]