[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: adding to the LSR

From: Reinhold Kainhofer
Subject: Re: adding to the LSR
Date: Wed, 29 Apr 2009 11:37:12 +0200
User-agent: KMail/1.11.2 (Linux/2.6.27-14-generic; KDE/4.2.2; i686; ; )

Hash: SHA1

On Dienstag, 28. April 2009 23:58:49 Carl D. Sorensen wrote:
> On 4/28/09 10:24 AM, "Jonathan Kulp" <address@hidden> wrote:
> > of my own files before.  The convert-ly script took the \octaves command
> > as if it were an octave check instead of a user-defined macro.  I've
> > changed the \octaves command in the original LSR code to \makeOctaves,
> > which will survive the convert-ly update intact.
> This probably also indicates a need to change the convert-ly rule for
> \octave.  If it doesn't work for \octaves, it also wouldn't work for
> \octaveAdjustFunction, or some other user-defined variable that starts with
> \octave.  This should be either fixed or added to the issue tracker to get
> fixed.

I think the solution is to simply check that no letter follows after \octave, 
This can be easiest done by a negative lookahead patter in the RegExp:
str = re.sub (r"\\octave(?![a-zA-Z])", r"\\octaveCheck", str)

Patch is at:

Okay to commit?

Notice that I only added the "(?![a-zA-Z])", which means: "Match the string 
only if the pattern [a-zA-Z] does not match. The resulting match does only 
contain the \octave, so the replacement string doesn't need to be changed.

> There are also some snippets that work but should be changed to reflect
> changes in 2.12.

Another is the X11 color list snippet.

> That's why I estimated 15 minutes per snippet (I wasn't thinking of
> automation, which I should have).  We should check each of the snippets and
> see if the snippet is made obsolete or should be changed to reflect new
> features added, not just check to see if the syntax is right.

Yes, but first we'd need to get the LSR up and running with 2.12, then we can 
update the snippets with new features and paradigm from 2.12.


- -- 
- ------------------------------------------------------------------
Reinhold Kainhofer, address@hidden,
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 *, DVR: 0005886
 * LilyPond, Music typesetting,
Version: GnuPG v1.4.9 (GNU/Linux)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]